Skip to content

Conversation

@lihaosky
Copy link
Contributor

@lihaosky lihaosky commented Jan 8, 2026

What is the purpose of the change

Add secret store related api in FLIP-529

Brief change log

  • SecretStore, SecretStoreFactory interfaces
  • Add secret-store kind config option
  • Use them in TableEnvironmentImpl and EnvironmentSettings

Verifying this change

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (JavaDocs)

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 8, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

? settings.getCatalogStore()
: catalogStoreFactory.createCatalogStore();

final SecretStoreFactory secretStoreFactory =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest adding a test implementation of these interfaces to drive the usage of the interfaces from tests, including writeable readable stores with config options.

@github-actions github-actions bot added the community-reviewed PR has been reviewed by the community. label Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants