Skip to content

Fix null reference exception in user agent handling #3946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
salmanmkc merged 3 commits into from
Jul 17, 2025
+1 −1
Merged

Fix null reference exception in user agent handling #3946

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51e6eee
Fix null ref
salmanmkc Jul 17, 2025
d7dbfd8
remove null check, not needed
salmanmkc Jul 17, 2025
28e8798
address pr comments again
salmanmkc Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Runner.Worker/JobRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,12 @@ public async Task<TaskResult> RunAsync(AgentJobRequestMessage message, Cancellat
if (message.Variables.TryGetValue(Constants.Variables.System.OrchestrationId, out VariableValue orchestrationId) &&
!string.IsNullOrEmpty(orchestrationId.Value))
{
if (!HostContext.UserAgents.Any(x => string.Equals(x.Product.Name, "OrchestrationId", StringComparison.OrdinalIgnoreCase)))
HostContext.LoadDefaultUserAgents();

if (HostContext.UserAgents != null && !HostContext.UserAgents.Any(x => string.Equals(x.Product?.Name, "OrchestrationId", StringComparison.OrdinalIgnoreCase)))
{
// make the orchestration id the first item in the user-agent header to avoid get truncated in server log.
HostContext.UserAgents.Insert(0, new ProductInfoHeaderValue("OrchestrationId", orchestrationId.Value));
HostContext.UserAgents?.Insert(0, new ProductInfoHeaderValue("OrchestrationId", orchestrationId.Value));
}

// make sure orchestration id is in the user-agent header.
Expand Down
Loading