switch to spyOn for mocks #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsciple
commented
Feb 11, 2020
| @@ -1,47 +1,44 @@ | |||
| import * as assert from 'assert' | |||
| import * as core from '@actions/core' | |||
Contributor
Author
There was a problem hiding this comment.
The previous code used genMockModule to hijack the module loader, and then require the module being tested during the beforeAll. The require was deferred to beforeAll because I had found the import order to be unreliable when esModuleInterop is set to true (recommended tsconfig setting).
Switching to spyOn(...).mockImplementation(...) instead, which allows everything to be imported as normal. Rather than late-bound require during beforeAll.
joshmgross
approved these changes
Feb 13, 2020
Contributor
Author
|
Going ahead and merging since this is just to align with the pattern established in setup go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.