Update to ESLint v9.23.0 and modernize config #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1d0b18 to
8a7140a
Compare
8a7140a to
fdc68db
Compare
fivetanley
reviewed
May 21, 2025
.github/workflows/test.yml
Outdated
| strategy: | ||
| matrix: | ||
| node-version: [12.x, 14.x, 16.x] | ||
| node-version: [18.18.x, 20.x] |
Collaborator
There was a problem hiding this comment.
Can we add 22.x here as well since it's the new LTS?
Collaborator
Author
There was a problem hiding this comment.
Sure thing! Added.
fivetanley
previously approved these changes
May 21, 2025
Collaborator
fivetanley
left a comment
There was a problem hiding this comment.
Small request that could be broken out into an another PR if need be. great job! thank you!
fivetanley
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to the latest syntax for eslint 9.23, the version used by the latest ember-new-output. It also bumps node versions to match what is accepted by eslint. A lot of the changes are just config changes, but one rule (
lib/rules/a11y-audit-after-test-helper.js) was rewritten based on tests. It updates all files to usemjsextensions as well. This PR touches everything, and I'm not sure if there's a way around that. Open to suggestions!This has been tested in our consuming app, and works as expected using both the recommended config and a custom config. Would be great if other apps could test it out as well :)