Skip to content

Deactivation Fixes #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stmitt merged 13 commits into from
Mar 21, 2022
Merged

Deactivation Fixes #516

stmitt merged 13 commits into from
Mar 21, 2022

Conversation

@stmitt
Copy link
Contributor

@stmitt stmitt commented Mar 19, 2022 •
edited
Loading

  • removes appclip from target
  • only switch to main thread if not already on main thread
  • cancel all pending and delivered notifications on deactivation

@stmitt stmitt changed the title Removes appclip Deactivation Fixes Mar 21, 2022
@stmitt stmitt requested a review from zimmermannubique March 21, 2022 07:37
@stmitt
Merge branch 'master' into feature/remove-appclip
b027e97 
# Conflicts:
#	DP3TApp/Supporting Files/Info.plist
#	DP3TAppClip/Info.plist
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stmitt stmitt merged commit 6f52f16 into develop Mar 21, 2022
@stmitt stmitt deleted the feature/remove-appclip branch March 21, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisjueni dennisjueni dennisjueni approved these changes

@simonroesch simonroesch Awaiting requested review from simonroesch

@UBaggeler UBaggeler Awaiting requested review from UBaggeler

@zimmermannubique zimmermannubique Awaiting requested review from zimmermannubique

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stmitt @dennisjueni