fix: Add missing pagination parameters to list_resources tool #108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the missing pagination parameters (
limitandcontinue) to the MCP tool schema definition for thelist_resourcestool.Problem
The pagination functionality was already implemented in the backend (in
pkg/k8s/client.goandpkg/mcp/list_resources.go), but the MCP tool schema definition inpkg/mcp/tools.gowas missing the parameter declarations. This meant that:Solution
Added the missing parameter definitions to the
NewListResourcesTool()function:limit(number): Maximum number of resources to return (0 means no limit, default: 0)continue(string): Continue token for pagination (use the value from previous response's ListMeta.Continue)Changes
mcp.WithNumber("limit", ...)parameter definitionmcp.WithString("continue", ...)parameter definitionTesting
The pagination functionality itself was already tested in the previous PR. This change only updates the schema definition to match the existing implementation.
Impact
This is a non-breaking change that: