Skip to content

Conversation

@crertel
Copy link
Contributor

@crertel crertel commented May 5, 2024

This finishes pulling in @GPrimola 's work that I merged in #17 .

We'll rebase here and have staging ground to pull in the functionality to the Cairo backend too.

@crertel crertel self-assigned this May 5, 2024
@crertel
Copy link
Contributor Author

crertel commented Jun 15, 2024

Ah, hell's bells...okay @ringlej I'm caught back up on this--is there any chance you can grab the Cairo side of this, or should I grab it? I think you've got a bit more context there than I do.

@ringlej
Copy link
Contributor

ringlej commented Jun 15, 2024

The only thing I'd mention here is that there isn't a Cairo implementation provided so anyone using it with Cairo will get a log message if the function is attempted with no rendering done.
That said, I'd rather this not hold up a release.

@ringlej
Copy link
Contributor

ringlej commented Jun 15, 2024

Right now I don't have the cycles to tackle this for Cairo.

@crertel
Copy link
Contributor Author

crertel commented Jun 15, 2024

Makes sense. Let's do a fast-follow then.

(let's here == "Chris will give it a shot later". not trying to give you work!)

@crertel crertel merged commit cf37613 into main Jun 15, 2024
@crertel crertel deleted the draw_rrectv branch June 15, 2024 23:12
@GPrimola
Copy link
Contributor

@crertel @ringlej I can do it for Cairo too! I'm almost sure when I did it for NVG there wasn't support for Cairo yet. Maybe? 🤔
Anyway, will do it in another PR.
Thanks!! :)

@crertel
Copy link
Contributor Author

crertel commented Jun 18, 2024

'preciate ya, @GPrimola!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants