Impl crypto_common::Generate trait
#1586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces various bespoke RNG APIs with the new `Generate` trait from `crypto_common`, which was added to `elliptic-curve` in RustCrypto/traits#2173. It's now a required bound for all affine/projective points and scalars, as well as the RNG API used by all generic types defined in the `elliptic-curve` crate itself. This API avoids having to directly import `getrandom::SysRng`, making it possible to call `T::generate()` instead so long as the `getrandom` feature of `elliptic-curve` is enabled.
tarcieri
added a commit
that referenced
this pull request
Jan 9, 2026
This fixes a critical security vulnerability originally reported as GHSA-w3g8-fp6j-wvqw by @XlabAITeam. Previously the module defined its own `next_k` function which invoked the `RandomBits::try_random_bits` API to generate a `k` value via rejection sampling, however it was passing previous calculation of the number of bytes to generate to an API expecting a number of bits. This bits/bytes confusion lead to highly biased values for `k` consisting of mostly zeros. Such a bias can be exploited for full plaintext recovery, and potentially key recovery. All ciphertexts ever encrypted using this API are vulnerable. This commit replaces the `next_k` function with the recently added `Scalar::try_generate_from_rng` method which uses the `Generate` trait impl'd in #1586, and is backed by the rejection sampling implemenatation from `crypto-bigint`.
tarcieri
added a commit
that referenced
this pull request
Jan 9, 2026
This fixes a critical security vulnerability originally reported as GHSA-w3g8-fp6j-wvqw by @XlabAITeam. Previously the module defined its own `next_k` function which invoked the `RandomBits::try_random_bits` API to generate a `k` value via rejection sampling, however it was passing previous calculation of the number of bytes to generate to an API expecting a number of bits. This bits/bytes confusion lead to highly biased values for `k` consisting of mostly zeros. Such a bias can be exploited for full plaintext recovery, and potentially key recovery. All ciphertexts ever encrypted using this API are vulnerable. This commit replaces the `next_k` function with the recently added `Generate` trait (#1586), using `NonZeroScalar::try_generate_from_rng` which is backed by the rejection sampling implemenatation from `crypto-bigint`.
tarcieri
added a commit
that referenced
this pull request
Jan 9, 2026
This fixes a critical security vulnerability originally reported as GHSA-w3g8-fp6j-wvqw by @XlabAITeam. Previously the module defined its own `next_k` function which invoked the `RandomBits::try_random_bits` API to generate a `k` value via rejection sampling, however it was passing previous calculation of the number of bytes to generate to an API expecting a number of bits. This bits/bytes confusion lead to highly biased values for `k` consisting of mostly zeros. Such a bias can be exploited for full plaintext recovery, and potentially key recovery. All ciphertexts ever encrypted using this API are vulnerable. This commit replaces the `next_k` function with the recently added `Generate` trait (#1586), using `NonZeroScalar::try_generate_from_rng` which is backed by the rejection sampling implemenatation from `crypto-bigint`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces various bespoke RNG APIs with the new
Generatetrait fromcrypto_common, which was added toelliptic-curvein RustCrypto/traits#2173.It's now a required bound for all affine/projective points and scalars, as well as the RNG API used by all generic types defined in the
elliptic-curvecrate itself.This API avoids having to directly import
getrandom::SysRng, making it possible to callT::generate()instead so long as thegetrandomfeature ofelliptic-curveis enabled.