Fix incorrect URLs generated for "Try it" feature #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generateEmptyData and getAppUrl methods updated;
hans-thomas
commented
Jan 15, 2025
DenTray
requested changes
Jan 21, 2025
DenTray
approved these changes
Jan 22, 2025
DenTray
approved these changes
Jan 22, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, The problem mentioned in #151 with the "Try it" feature is the server URL, which is without the
http(s)://schema. The document viewers expect the server URL to start withhttp://orhttps://prefix. Otherwise, consider the server URL as a route and that's why it's prepend the server URL in "Try it" feature.