build: Use Gradle credentials system #109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR modernizes the Gradle authentication approach by switching from manual credential configuration to Gradle's built-in PasswordCredentials system for authenticating with GitHub Packages. This change simplifies credential management and aligns with Gradle best practices.
Key changes:
- Replaced manual credentials block in
build.gradle.ktswithcredentials(PasswordCredentials::class) - Added repository name "GitHubPackages" for proper credential property mapping
- Updated GitHub Actions workflows to pass credentials via Gradle project properties
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| build.gradle.kts | Simplified credentials configuration by switching to PasswordCredentials system and adding repository name |
| .github/workflows/release.yml | Updated to pass GitHub credentials via Gradle project properties for the build step |
| .github/workflows/build_pull_request.yml | Updated to pass GitHub credentials via Gradle project properties for the build step |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to PasswordCredentials when during authentication with ghcr
nts:
List of what repository have PR submitted see: ReVanced/revanced-manager-downloader-template#16 (comment)