Skip to content

[components][net][lwip][port] Fix next-hop finding in lwip_ip4_route_src. #7504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Guozhanxin merged 3 commits into from
May 17, 2023
Merged

[components][net][lwip][port] Fix next-hop finding in lwip_ip4_route_src. #7504

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92574a1
Fix next-hop finding in lwip_ip4_route_src.
ttnwosay May 15, 2023
8958093
Fix netdev_ping issue.
ttnwosay May 15, 2023
c95b780
Revert "Fix netdev_ping issue."
ttnwosay May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions components/net/lwip/port/sys_arch.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,24 +675,24 @@ struct netif *lwip_ip4_route_src(const ip4_addr_t *dest, const ip4_addr_t *src)
{
struct netif *netif;

if (src == NULL)
return NULL;

/* iterate through netifs */
for (netif = netif_list; netif != NULL; netif = netif->next)
{
/* is the netif up, does it have a link and a valid address? */
if (netif_is_up(netif) && netif_is_link_up(netif) && !ip4_addr_isany_val(*netif_ip4_addr(netif)))
{
/* gateway matches on a non broadcast interface? (i.e. peer in a point to point interface) */
if (src != NULL)
/* source ip address equals netif's ip address? */
if (ip4_addr_cmp(src, netif_ip4_addr(netif)))
{
if (ip4_addr_cmp(src, netif_ip4_addr(netif)))
{
return netif;
}
return netif;
}
}
}
netif = netif_default;
return netif;

return NULL;
}
#endif /* LWIP_HOOK_IP4_ROUTE_SRC */
#endif /*LWIP_VERSION_MAJOR >= 2 */
Expand Down