mf-pr #254
mf-pr #254
Conversation
this is managed by the module isntead
ThePedroo
left a comment
There was a problem hiding this comment.
LGTM, though just small bits that require changes.
| }; | ||
|
|
||
| struct ksu_set_feature_cmd { | ||
| uint32_t feature_id; // Input: feature ID (enum ksu_feature_id) |
There was a problem hiding this comment.
Please remove the comment from this line and below to match the other structures.
|
|
||
| ksu_uses_new_ksuctl = true; | ||
|
|
||
| struct ksu_set_feature_cmd cmd = {0}; |
There was a problem hiding this comment.
struct ksu_set_feature_cmd cmd = {
.feature_id = 1,
.value = 0
};
Instead
| cmd.feature_id = (uint32_t)1; | ||
| cmd.value = (uint64_t)0; | ||
|
|
||
| /* we don't care about the reply */ |
There was a problem hiding this comment.
| /* we don't care about the reply */ | |
| /* INFO: Regardless of its response, we follow the same path. Ignore response. */ |
|
oh, I thought you didnt like it, so I deleted the repo yesterday. but this is something you might want to do now that ksu exposed umount, I'm not really up for fixing nitpicks when its essentially the same thing. |
|
I'm not sure if we'll benefit much from its usage when the code for umount is unified -- Introducing support to have KSU handle that will not only limit future flexibility but also introduce additional code without any benefits. I will be commiting this PR changes and credit you approprietly. Thank you. Next time, please don't rush to close it. I usually prefer to review in my PC, though this one you closed while I was reviewing on mobile LOL |
|
no, the fucking point is that you can take over over kernelsu's kernel umount and properly announce it. There is no benefit for rezygisk, the benefit is on the manager and its umount subsystem being disabled. |
|
Please be respectful here. Yes, if you mean just its disable, indeed. However I was talking about the other features added in the refered commit, as this one has been already proven to be useful. |
|
oh the one on upstream removes hardcoded umount mountpoints and hands it to userspace for full control. |
This commit makes ReZygisk signal to KernelSU to not perform umount inside the kernel, as ReZygisk will already handle the umount process. Original code from PR #254. Co-Authored-By: backslashxx <[email protected]>
This commit makes ReZygisk signal to KernelSU to not perform umount inside the kernel, as ReZygisk will already handle the umount process. Original code from PR #254. Co-Authored-By: backslashxx <[email protected]>
This commit makes ReZygisk signal to KernelSU to not perform umount inside the kernel, as ReZygisk will already handle the umount process. Original code from PR PerformanC#254. Co-Authored-By: backslashxx <[email protected]>
No description provided.