Skip to content

Implementation of RFC 36 #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zimbatm merged 2 commits into from
Jan 8, 2019
Merged

Implementation of RFC 36 #38

zimbatm merged 2 commits into from
Jan 8, 2019

Conversation

@globin
Copy link
Member

@globin globin commented Jan 7, 2019

see #36

Please check I haven't miscopied anything.

cc @NixOS/rfc-steering-committee @zimbatm @grahamc

shlevy
shlevy suggested changes Jan 7, 2019
View reviewed changes
Copy link
Member

@shlevy shlevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, otherwise looks good!

grahamc
grahamc approved these changes Jan 7, 2019
View reviewed changes
Copy link
Member

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 ❄️

@zimbatm zimbatm merged commit d9aad92 into NixOS:master Jan 8, 2019
@globin globin mentioned this pull request Apr 28, 2019
Merged
@globin globin deleted the rfc-36-impl branch July 2, 2019 13:06
KAction pushed a commit to KAction/rfcs that referenced this pull request Apr 13, 2024
@globin
Implementation of RFC 36 (NixOS#38)
78e548f 
* Implementation of RFC 36

see NixOS#36

* Fix reference to 'this RFC' -> RFC NixOS#36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@grahamc grahamc grahamc approved these changes

@shlevy shlevy shlevy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@globin @grahamc @shlevy @zimbatm