pythonPackages.toPythonModule: also support overridePythonAttrs.
#95687
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `overridePythonAttrs` method is for overriding `buildPython*` builders. Packages that use `toPythonModule` directly are typically bindings build not using `buildPython*`. This commit allows also those packages to be overridden with `overridePythonAttrs`, insteading actually invoking `overrideAttrs`. The motivation for this is to offer a common user interface for users of the Python packages set. This way they only need to know about `overridePythonAttrs` when overriding the builder, and `override` when overriding the `callPackage` call. Related RFC NixOS/rfcs#67.
drewrisinger
approved these changes
Aug 17, 2020
Contributor
drewrisinger
left a comment
There was a problem hiding this comment.
Sounds good/reasonable to me.
- Diff LGTM
- Commits LGTM
- Build: no build attempted
infinisil
requested changes
Aug 17, 2020
| }); | ||
| }) // { | ||
| overridePythonAttrs = drv.overrideAttrs; | ||
| }; |
Member
There was a problem hiding this comment.
Problems:
- This is not composable: You can't
overridePythonAttrstwice overrideAttrsdoesn't support non-functions, so.overridePythonAttrs {}fails, leading to inconsistent behavior with theoverridePythonAttrsthatmakeOverridablePythonPackagedefines.
Member
Author
There was a problem hiding this comment.
I see. Any suggestion how this can be resolved by adding the override option after the original function (stdenv.mkDerivation) has already been called? This here also seems a case where NixOS/rfcs#3 would be helpful.
Member
There was a problem hiding this comment.
Usually this is done by calling the original function again, but I think this get really messy with multiple ways to override things. Maybe look at the implementation of makeOverridable
|
I marked this as stale due to inactivity. → More info |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
overridePythonAttrsmethod is for overridingbuildPython*builders. Packages that use
toPythonModuledirectly are typicallybindings build not using
buildPython*.This commit allows also those packages to be overridden with
overridePythonAttrs, insteading actually invokingoverrideAttrs.The motivation for this is to offer a common user interface for users of
the Python packages set. This way they only need to know about
overridePythonAttrswhen overriding the builder, andoverridewhenoverriding the
callPackagecall.Related RFC NixOS/rfcs#67.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)