Skip to content

python3Packages.returns: fix test and re-enable mypy tests #476911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SuperSandro2000 merged 2 commits into from
Jan 7, 2026
Merged

python3Packages.returns: fix test and re-enable mypy tests #476911

SuperSandro2000 merged 2 commits into from
Jan 7, 2026

Conversation

@linsui
Copy link
Contributor

@linsui linsui commented Jan 4, 2026

Things done

Mypy was disabled in dd9c0b8. CC @SuperSandro2000. The cov tests are not re-enabled because covdefaults is required but it's not packaged.

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@linsui linsui changed the title python3Packages: fix test and re-enable mypy tests python3Packages.returns: fix test and re-enable mypy tests Jan 4, 2026
@linsui linsui requested a review from SuperSandro2000 January 4, 2026 17:40
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Jan 4, 2026
@phanirithvij

This comment was marked as resolved.

Sign in to view
@linsui
Copy link
Contributor Author

linsui commented Jan 5, 2026

Fixed on python 3.14.

@nixpkgs-ci nixpkgs-ci bot requested review from dotlambda and fabaff January 5, 2026 17:49
@phanirithvij

This comment was marked as resolved.

Sign in to view
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 7, 2026
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 7, 2026
@phanirithvij
Copy link
Member

phanirithvij commented Jan 7, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 476911
Commit: 39c0ab7e9a06ef561b13a6b47f99949614179ffa (subsequent changes)
Merge: 96654342dbc15dfc982fcf1edd93f344296dd665

Logs: https://github.com/phanirithvij/nixpkgs-review-gha/actions/runs/20789763526

x86_64-linux

✅ 15 packages built:
  • home-assistant-component-tests.solarlog
  • python313Packages.pytest-aio
  • python313Packages.pytest-aio.dist
  • python313Packages.returns
  • python313Packages.returns.dist
  • python313Packages.solarlog-cli
  • python313Packages.solarlog-cli.dist
  • python314Packages.pytest-aio
  • python314Packages.pytest-aio.dist
  • python314Packages.returns
  • python314Packages.returns.dist
  • python314Packages.solarlog-cli
  • python314Packages.solarlog-cli.dist
  • yutto
  • yutto.dist

aarch64-linux

✅ 15 packages built:
  • home-assistant-component-tests.solarlog
  • python313Packages.pytest-aio
  • python313Packages.pytest-aio.dist
  • python313Packages.returns
  • python313Packages.returns.dist
  • python313Packages.solarlog-cli
  • python313Packages.solarlog-cli.dist
  • python314Packages.pytest-aio
  • python314Packages.pytest-aio.dist
  • python314Packages.returns
  • python314Packages.returns.dist
  • python314Packages.solarlog-cli
  • python314Packages.solarlog-cli.dist
  • yutto
  • yutto.dist

x86_64-darwin (sandbox = true)

✅ 14 packages built:
  • python313Packages.pytest-aio
  • python313Packages.pytest-aio.dist
  • python313Packages.returns
  • python313Packages.returns.dist
  • python313Packages.solarlog-cli
  • python313Packages.solarlog-cli.dist
  • python314Packages.pytest-aio
  • python314Packages.pytest-aio.dist
  • python314Packages.returns
  • python314Packages.returns.dist
  • python314Packages.solarlog-cli
  • python314Packages.solarlog-cli.dist
  • yutto
  • yutto.dist

aarch64-darwin (sandbox = true)

✅ 14 packages built:
  • python313Packages.pytest-aio
  • python313Packages.pytest-aio.dist
  • python313Packages.returns
  • python313Packages.returns.dist
  • python313Packages.solarlog-cli
  • python313Packages.solarlog-cli.dist
  • python314Packages.pytest-aio
  • python314Packages.pytest-aio.dist
  • python314Packages.returns
  • python314Packages.returns.dist
  • python314Packages.solarlog-cli
  • python314Packages.solarlog-cli.dist
  • yutto
  • yutto.dist

@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Jan 7, 2026
Merged via the queue into NixOS:master with commit 8280bbe Jan 7, 2026
27 of 31 checks passed
dotlambda
dotlambda reviewed Jan 7, 2026
View reviewed changes
pkgs/development/python-modules/returns/default.nix
httpx
hypothesis
# https://github.com/dry-python/returns/issues/2224
(hypothesis.overrideAttrs (old: {
Copy link
Member

@dotlambda dotlambda Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new attribute in python-packages.nix: #421201

@linsui linsui deleted the yutto branch January 8, 2026 07:20
@linsui linsui mentioned this pull request Jan 8, 2026
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotlambda dotlambda dotlambda left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@fabaff fabaff Awaiting requested review from fabaff

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@linsui @phanirithvij @dotlambda @SuperSandro2000