-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
pkgs/by-name: add version pins #464396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
pkgs/by-name: add version pins #464396
Conversation
|
Conceptually looks good, what are next steps for this pr? |
|
probably get the rfc merged first, or do you think this is small enough to be done without the rfc? |
|
we do need to hear opinion of @NixOS/nixpkgs-core at least |
I'm not sure what the question to the core team here is. The core team generally is not a code owner that should be pinged for review. However, if local consensus can't be reached, we can surely help out. In this case, the PR is a draft to support an ongoing RFC. The RFC is not done, yet. The PR fails CI. Nothing to do here. |
Proof of concept implementation of NixOS/rfcs#192
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.