libcava: add myself to maintainers #453591
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotlambda
reviewed
Oct 19, 2025
| meta = old.meta // { | ||
| homepage = "https://github.com/LukashonakV/cava"; | ||
| description = "Fork of CAVA to build it as a shared library"; | ||
| maintainers = old.meta.maintainers ++ [ lib.maintainers.perchun ]; |
Member
There was a problem hiding this comment.
Suggested change
| maintainers = old.meta.maintainers ++ [ lib.maintainers.perchun ]; | |
| maintainers = [ lib.maintainers.perchun ]; |
Member
Author
There was a problem hiding this comment.
It is, but this fork uses almost identical build structure, and duplicating all the work to libcava and cava only creates more maintenance burden than it solves. Also, the maintainers of cava don't seem to mind being maintainers of libcava (as those are nearly identical from the packager's point of view)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added this package in #368312, probably forgot to add myself to the maintainers
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.