Skip to content

Conversation

@albertlarsan68
Copy link
Member

@albertlarsan68 albertlarsan68 commented Sep 9, 2025

Adds the CUDA plugin for xmrig and xmrig-mo.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 12.first-time contribution This PR is the author's first one; please be gentle! 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Sep 9, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Sep 11, 2025
Copy link
Contributor

@ConnorBaker ConnorBaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits; haven't had a chance to build these or try running them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use overrideAttrs (#421201) or rec -- instead create a separate derivation for this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a mirror of how xmrig and xmrig-mo are done, but I'm open to try another solution.

Comment on lines 22 to 29
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the PR hasn't been merged, it may change if the author force-pushes it. I'd recommend either fetching the two patches in the PR by commit (which should stick around forever) or vendoring them in-tree.

@ConnorBaker ConnorBaker added the 6.topic: cuda Parallel computing platform and API label Sep 11, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 6.topic: cuda Parallel computing platform and API label Sep 11, 2025
@albertlarsan68
Copy link
Member Author

I tested that it works on an RTX 4050, using the xmrig-on-a-stick with this version:

https://git.sr.ht/~albertlarsan68/dotfiles/tree/5fa964999df9640a3a1553b93445c298e5961054

@albertlarsan68
Copy link
Member Author

@qzylinra and @ConnorBaker can I please have a review?

@ConnorBaker ConnorBaker added this pull request to the merge queue Oct 2, 2025
@ConnorBaker ConnorBaker moved this from New to 👀 Awaits reviews in CUDA Team Oct 2, 2025
@ConnorBaker ConnorBaker moved this from 👀 Awaits reviews to 🔖 Awaits the merge in CUDA Team Oct 2, 2025
Merged via the queue into NixOS:master with commit 60f34a2 Oct 2, 2025
30 of 31 checks passed
@github-project-automation github-project-automation bot moved this from 🔖 Awaits the merge to ✅ Done in CUDA Team Oct 2, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 2, 2025
@albertlarsan68 albertlarsan68 deleted the xmrig-cuda branch October 2, 2025 19:07
@albertlarsan68 albertlarsan68 restored the xmrig-cuda branch October 3, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants