-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
xmrig-cuda{,-mo}: init at 6.22.1{,-mo1} #441494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
19acd8e to
ed43b8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits; haven't had a chance to build these or try running them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use overrideAttrs (#421201) or rec -- instead create a separate derivation for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a mirror of how xmrig and xmrig-mo are done, but I'm open to try another solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the PR hasn't been merged, it may change if the author force-pushes it. I'd recommend either fetching the two patches in the PR by commit (which should stick around forever) or vendoring them in-tree.
ed43b8f to
99d4c18
Compare
|
I tested that it works on an RTX 4050, using the xmrig-on-a-stick with this version: https://git.sr.ht/~albertlarsan68/dotfiles/tree/5fa964999df9640a3a1553b93445c298e5961054 |
|
@qzylinra and @ConnorBaker can I please have a review? |
Adds the CUDA plugin for xmrig and xmrig-mo.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.