Skip to content

immich: 1.140.1 -> 1.142.0 #441343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dotlambda merged 2 commits into from
Sep 12, 2025
Merged

immich: 1.140.1 -> 1.142.0 #441343

dotlambda merged 2 commits into from
Sep 12, 2025

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Sep 9, 2025 •
edited
Loading

Diff: immich-app/immich@v1.140.1...v1.142.0

Changelog:
https://github.com/immich-app/immich/releases/tag/v1.141.1
https://github.com/immich-app/immich/releases/tag/v1.142.0

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Sep 9, 2025
@dotlambda dotlambda marked this pull request as draft September 9, 2025 02:36
@dotlambda dotlambda marked this pull request as ready for review September 9, 2025 03:23
@dotlambda dotlambda force-pushed the immich branch 2 times, most recently from 0bca784 to c6987e2 Compare September 9, 2025 03:26
@uku3lig
Copy link
Member

uku3lig commented Sep 10, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 441343
Commit: c6987e2f7ffa2ba0da3e496fdda914bea3eab57a

x86_64-linux

✅ 4 packages built:
  • immich
  • immich-cli
  • immich-machine-learning
  • immich-machine-learning.dist

@uku3lig
Copy link
Member

uku3lig commented Sep 10, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 441343 --package immich.tests
Commit: c6987e2f7ffa2ba0da3e496fdda914bea3eab57a

x86_64-linux

✅ 2 packages built:
  • immich.tests.immich
  • immich.tests.immich-vectorchord-migration

@uku3lig uku3lig added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 10, 2025
@dotlambda dotlambda force-pushed the immich branch 2 times, most recently from c912bb0 to 302d61c Compare September 11, 2025 05:08
@dotlambda
Copy link
Member Author

dotlambda commented Sep 11, 2025 •
edited
Loading

@anthonyroussel @sternenseemann Immich now depends on vips 8.17. Should I add vips_8_17 and have only immich use that or add vips_8_16 and have only haskellPackages.gi-vips use that?
I previously used an override (see c912bb0b4474e3bce6f1bd2979a46ea89ca6ebb1) but that goes against #421201.
Honestly I'd even be fine with leaving haskellPackages.gi-vips broken for a while because that's a library without users in Nixpkgs.

@nixpkgs-ci nixpkgs-ci bot removed the 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. label Sep 11, 2025
@dotlambda
Copy link
Member Author

dotlambda commented Sep 12, 2025

Honestly I'd even be fine with leaving haskellPackages.gi-vips broken for a while because that's a library without users in Nixpkgs.

I went for that option and cherry-picked the commit from #429195.

@dotlambda dotlambda changed the title immich: 1.140.1 -> 1.141.1 immich: 1.140.1 -> 1.142.0 Sep 12, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Sep 12, 2025
@dotlambda dotlambda enabled auto-merge September 12, 2025 21:33
@dotlambda dotlambda added this pull request to the merge queue Sep 12, 2025
Merged via the queue into NixOS:master with commit 2e74f14 Sep 12, 2025
27 of 31 checks passed
@dotlambda dotlambda deleted the immich branch September 12, 2025 21:39
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Sep 12, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Sep 12, 2025
@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Sep 12, 2025
Closed
1 task
@diogotcorreia diogotcorreia mentioned this pull request Sep 23, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Scrumplex Scrumplex Awaiting requested review from Scrumplex

@jvanbruegge jvanbruegge Awaiting requested review from jvanbruegge

@Titaniumtown Titaniumtown Awaiting requested review from Titaniumtown

@KoviRobi KoviRobi Awaiting requested review from KoviRobi

@anthonyroussel anthonyroussel Awaiting requested review from anthonyroussel

1 more reviewer

@uku3lig uku3lig uku3lig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dotlambda @uku3lig @anthonyroussel