rofi-{emoji,rbw}: move to pkgs/by-name, update and remove some antipatterns #410737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
One question: how can I move |
0f23732 to
5d71a33
Compare
bew
reviewed
Jun 1, 2025
Contributor
bew
left a comment
There was a problem hiding this comment.
Thanks for this! Just a few comments ;)
Contributor
Author
|
Nope, I did, nevermind |
cole-h
approved these changes
Jun 3, 2025
Member
cole-h
left a comment
There was a problem hiding this comment.
rofi-emoji-wayland still works for me after this*. LGTM.
(* I manually specified the -plugin-path out of laziness)
Mange
approved these changes
Jun 7, 2025
Contributor
Mange
left a comment
There was a problem hiding this comment.
I don't mind the changes to rofi-emoji, although I do question overriding apps with completely different apps in some contexts.
972435e to
e0495e4
Compare
e0495e4 to
5761c1b
Compare
- pyprojectize the recipe - buildInputs were useless - wrapper paths and flags belonged in a `let..in`
it's executable, so it gets patchShebang-ed in fixupPhase anyway
Contributor
Author
|
Contributor
Author
fucking finally 😩🙏 |
cole-h
approved these changes
Oct 22, 2025
Member
cole-h
left a comment
There was a problem hiding this comment.
Seems fine to me. Let's get this in before any more painful merge conflicts ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.