-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
nixos/auto-upgrade: introduce the concept of desync, for often-failing packages #385143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
f4f301d
nixos/auto-upgrade: introduce the concept of desync, for often-failin…
Ekleog 4e2110f
nixos/auto-upgrade: run nixfmt
Ekleog 9a9eb01
handle review comments
Ekleog d027c02
nixfmt
Ekleog 463f768
review comments
Ekleog f1da502
use a declarative container for the example
Ekleog 212e6e3
also document the dangers of mix-and-matching packages
Ekleog 84d0d26
fix typo
Ekleog 6497445
symlink instead of copying out of the store, to keep the gc root aliv…
Ekleog 9a18d01
avoid remembering /nix/var/nix if a desync literally never built fine
Ekleog 56a8a15
Merge remote-tracking branch 'upstream/master' into desync
Ekleog 0a3db5d
write release notes
Ekleog d92a223
review comments
Ekleog b625e4b
Merge remote-tracking branch 'upstream/master' into desync
Ekleog ec02d51
fix manual build
Ekleog 7d1a2bf
nixfmt
Ekleog b241bd1
remove example tag
Ekleog 3b2ae02
no double-escape
Ekleog ddf7ee3
add links to docs
Ekleog c6fcd89
fix release notes
Ekleog dd416fe
use pkgs.path
Ekleog e72f51d
fix mistake in merge resolution
Ekleog f36e70d
fix manual build
Ekleog e5d35ef
third attempt at proper manual building, if manual took less time to …
Ekleog f425694
unlink a non-option to fix manual build
Ekleog 8ecffc1
hopefully fix ci
Ekleog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Factoring this out should be its own commit. This is one of the reasons the commit history needs to be cleaned up and not just squashed.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I answered that in my answer to your first comment too. Same as the options linking, if this is the only thing blocking merging I'll do it; but considering the fact that last time I finished "fixing the only thing that blocked merging" I'll wait for a signal that this can land before making further efforts on the code part. For example if the thumbs up go up in the first post, or if people who previously voiced negative opinions voice positive opinions.