Skip to content

Conversation

@KAction
Copy link
Contributor

@KAction KAction commented Jan 26, 2024

Supporting code for proposed RFC0169

nix-repl> cmus.override { alsaSupport = false; }
trace: warning: Feature parameter 'alsaSupport' is deprecated in favor of 'with_alsa'.
«derivation /nix/store/jm87wmcnpibrxfzwz95i51zh2qdxxp32-cmus-2.10.0.drv»

nix-repl> cmus.override { with_alsa = false; }
«derivation /nix/store/jm87wmcnpibrxfzwz95i51zh2qdxxp32-cmus-2.10.0.drv»

@github-actions github-actions bot added the 6.topic: lib The Nixpkgs function library label Jan 26, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 26, 2024
@KAction
Copy link
Contributor Author

KAction commented Jan 27, 2024

I did some compraison of evaluation time. As far as time concerned, I can't see any difference, but stats for nix-instantiate -A cmus say:

-  "nrFunctionCalls": 640435,
+  "nrFunctionCalls": 648806,

which means 1.3% more function calls. If I evaluate something big, but without anything renamed, like emacs, I get following:

-  "nrFunctionCalls": 451758,
+  "nrFunctionCalls": 457842,

which is also 1.3% more function calls.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 27, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: lib The Nixpkgs function library 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants