-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix: BROS-664: Fix XSS via script injection in custom hotkeys #9084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #9084 +/- ##
============================================
+ Coverage 66.66% 81.53% +14.86%
============================================
Files 832 271 -561
Lines 65129 24501 -40628
Branches 10988 0 -10988
============================================
- Hits 43419 19976 -23443
+ Misses 21706 4525 -17181
+ Partials 4 0 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@copilot review |
|
@nick-skriabin I've opened a new pull request, #9085, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
Cursor review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no bugs!
|
/fmt |
Addresses https://github.com/HumanSignal/label-studio/security/advisories/GHSA-2mq9-hm29-8qch
Note
Hardens client boot script against XSS from
user.custom_hotkeysand adds a small templating utility.replacefor simple substring replacementbase.html, escapes<and>inuser.custom_hotkeysvia|json_dumps_ensure_ascii|replace:"<|<"|replace:">|>"|safebefore injecting into__customHotkeysWritten by Cursor Bugbot for commit c4839fc. This will update automatically on new commits. Configure here.