Skip to content

Fixed boolean indexer mismatching issue #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinmessiaen merged 6 commits into from
Nov 12, 2024
Merged

Fixed boolean indexer mismatching issue #2071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
32b8b37
Fixed boolean indexer mismatching issue
kevinmessiaen Nov 12, 2024
09a7ee3
Use pdm head until next release
kevinmessiaen Nov 12, 2024
e69b1c6
Use values instead of reindexing
kevinmessiaen Nov 12, 2024
fe9a50d
Update Check if wheel can be installed with PDM
kevinmessiaen Nov 12, 2024
5d8da8b
pdm init broken with pdm>=3.20
kevinmessiaen Nov 12, 2024
0b23355
Fix pdm init
kevinmessiaen Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/build-python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ jobs:
uses: pdm-project/setup-pdm@v4
with:
python-version: ${{ matrix.python-version }}
version: head # Issue with PDM 2.20.1: https://github.com/pdm-project/pdm/issues/3271
cache: false

- name: Cache Giskard test resources
Expand Down Expand Up @@ -251,6 +252,7 @@ jobs:
uses: pdm-project/setup-pdm@v4
with:
python-version: "3.10"
version: head # Issue with PDM 2.20.1: https://github.com/pdm-project/pdm/issues/3271
cache: false
- name: Build wheel
run: pdm build
Expand All @@ -273,6 +275,7 @@ jobs:
uses: pdm-project/setup-pdm@v4
with:
python-version: "3.10"
version: head # Issue with PDM 2.20.1: https://github.com/pdm-project/pdm/issues/3271
cache: false
- name: Build wheel
run: pdm build
Expand All @@ -292,15 +295,15 @@ jobs:
uses: pdm-project/setup-pdm@v4
with:
python-version: "3.10"
version: "2.10.4" # Fix to repair the CI, use latest version when fixed on pdm
version: head # Issue with PDM 2.20.1: https://github.com/pdm-project/pdm/issues/3271
cache: false
- name: Build wheel
run: pdm build
- name: Create new project, install wheel and import (PDM)
run: |
mkdir ./install-run
cd ./install-run
pdm init --python 3.10 -n .
pdm init --python 3.10 -n
sed -i 's/^\(requires-python *= *\).*$/\1">=3.10,<3.12"/' pyproject.toml
pdm add "$(ls ../dist/*.whl)"
pdm run python -c "import giskard"
Expand Down Expand Up @@ -336,6 +339,7 @@ jobs:
uses: pdm-project/setup-pdm@v4
with:
python-version: "3.10"
version: head # Issue with PDM 2.20.1: https://github.com/pdm-project/pdm/issues/3271
cache: false

- name: Set up Pandoc (needed for doc)
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/create-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ jobs:
uses: pdm-project/setup-pdm@v4
with:
python-version: '3.10'
version: head # Issue with PDM 2.20.1: https://github.com/pdm-project/pdm/issues/3271
cache: false

- name: "@slack Release process started"
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/lock-deps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ jobs:
uses: pdm-project/setup-pdm@v4
with:
python-version: "3.10"
version: head # Issue with PDM 2.20.1: https://github.com/pdm-project/pdm/issues/3271
cache: false

- name: Install dependencies
Expand Down
2 changes: 1 addition & 1 deletion giskard/testing/tests/statistic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def test_output_in_range(
output = prediction_results.raw_prediction

elif model.is_classification:
output = prediction_results.all_predictions[classification_label]
output = prediction_results.all_predictions[classification_label].values

else:
raise ValueError(f"Prediction task is not supported: {model.meta.model_type}")
Expand Down