Skip to content

Conversation

@kevinmessiaen
Copy link
Member

@kevinmessiaen kevinmessiaen commented May 23, 2024

Description

Remove noise by filtering error that arise outside of giskard (ei. in jupiter notebook)

Example:

# initialize sentry reporting by importing giskard
import giskard 

# Report an error even though it is totally unrelated to giskard (fixed by this PR)
val = 1 / 0

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

@kevinmessiaen kevinmessiaen requested a review from henchaves May 24, 2024 06:53
@kevinmessiaen kevinmessiaen enabled auto-merge June 10, 2024 02:17
@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud

@kevinmessiaen kevinmessiaen merged commit 892443e into main Jun 10, 2024
@kevinmessiaen kevinmessiaen deleted the feature/filter_sentry_error_repporting branch June 10, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants