Skip to content

fix(restore): replace USE statements with target database during restore #3437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CebRazvan wants to merge 1 commit into
base: canary
Choose a base branch
from
Open

fix(restore): replace USE statements with target database during restore #3437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/server/src/utils/restore/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,18 @@ export const getMariadbRestoreCommand = (
databaseUser: string,
databasePassword: string,
) => {
return `docker exec -i $CONTAINER_ID sh -c "mariadb -u '${databaseUser}' -p'${databasePassword}' ${database}"`;
// Use sed to replace any USE `database` statements with the target database
// This prevents restoring into wrong database when backup contains USE statements
return `sed "s/USE \\\`[^\\\`]*\\\`/USE \\\`${database}\\\`/g" | docker exec -i $CONTAINER_ID sh -c "mariadb -u '${databaseUser}' -p'${databasePassword}' ${database}"`;
};

export const getMysqlRestoreCommand = (
database: string,
databasePassword: string,
) => {
return `docker exec -i $CONTAINER_ID sh -c "mysql -u root -p'${databasePassword}' ${database}"`;
// Use sed to replace any USE `database` statements with the target database
// This prevents restoring into wrong database when backup contains USE statements
return `sed "s/USE \\\`[^\\\`]*\\\`/USE \\\`${database}\\\`/g" | docker exec -i $CONTAINER_ID sh -c "mysql -u root -p'${databasePassword}' ${database}"`;
};

export const getMongoRestoreCommand = (
Expand Down