Skip to content

codesign macos apps #5055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkelleyrtp merged 4 commits into from
Dec 4, 2025
Merged

codesign macos apps #5055

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62a2896
wip
jkelleyrtp Nov 25, 2025
1abc4d5
Merge remote-tracking branch 'origin/main' into jk/codesign-macos
jkelleyrtp Dec 4, 2025
82ca82b
rollback readme
jkelleyrtp Dec 4, 2025
107bc60
change language
jkelleyrtp Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions packages/cli/src/build/request.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4370,10 +4370,10 @@ __wbg_init({{module_or_path: "/{}/{wasm_path}"}}).then((wasm) => {{
);
}
}
BundleFormat::Ios => {
BundleFormat::MacOS | BundleFormat::Ios => {
if self.should_codesign {
ctx.status_codesigning();
self.codesign_ios().await?;
self.codesign_apple().await?;
}
}

Expand Down Expand Up @@ -5254,23 +5254,22 @@ __wbg_init({{module_or_path: "/{}/{wasm_path}"}}).then((wasm) => {{
.collect()
}

pub async fn codesign_ios(&self) -> Result<()> {
pub async fn codesign_apple(&self) -> Result<()> {
// We don't want to drop the entitlements file, until the end of the block, so we hoist it to this temporary.
let mut _saved_entitlements = None;

let mut app_dev_name = self.apple_team_id.clone();
if app_dev_name.is_none() {
app_dev_name =
Some(Self::auto_provision_signing_name().await.context(
"Failed to automatically provision signing name for iOS codesigning.",
)?);
app_dev_name = Some(Self::auto_provision_signing_name().await.context(
"Failed to automatically provision signing name for Apple codesigning.",
)?);
}

let mut entitlements_file = self.apple_entitlements.clone();
if entitlements_file.is_none() {
let entitlements_xml = Self::auto_provision_entitlements()
.await
.context("Failed to auto-provision entitlements for iOS codesigning.")?;
.context("Failed to auto-provision entitlements for Apple codesigning.")?;
let entitlements_temp_file = tempfile::NamedTempFile::new()?;
std::fs::write(entitlements_temp_file.path(), entitlements_xml)?;
entitlements_file = Some(entitlements_temp_file.path().to_path_buf());
Expand All @@ -5285,7 +5284,7 @@ __wbg_init({{module_or_path: "/{}/{wasm_path}"}}).then((wasm) => {{
)?;

tracing::debug!(
"Codesigning iOS app with entitlements: {} and dev name: {}",
"Codesigning Apple app with entitlements: {} and dev name: {}",
entitlements_file.display(),
app_dev_name
);
Expand Down