Resolves #5045: Trim slashes to prevent base path resolution issues in web

[binarypie]

Normalize the base path when set to / to prevent routing and asset resolution errors in web. This resolves #5045.

[ealmloff]

Thanks! Could you move this normalization to when DIOXUS_ASSET_ROOT is set instead of when it is read?

Then we don't need to rerun it every time we read the base path. It could also be in the head instead of the env var depending on the platform.

[binarypie]

Thanks! Could you move this normalization to when DIOXUS_ASSET_ROOT is set instead of when it is read?

Then we don't need to rerun it every time we read the base path. It could also be in the head instead of the env var depending on the platform.

Sure can!

[binarypie]

This approach covers all three ways (cli, toml, env var) the base_path can be set.

In fact it is likely true that this code in request.rs could be removed. However, I was unsure of the ramifications of doing so.

/// Get the normalized base path for the application with `/` trimmed from both ends. If the base path is not set, this will return `.`.
    pub(crate) fn base_path_or_default(&self) -> &str {
        let trimmed_path = self.base_path().unwrap_or_default().trim_matches('/');
        if trimmed_path.is_empty() {
            "."
        } else {
            trimmed_path
        }
    }

Another point to note. Simply modifying where we internally set DIOXUS_ASSET_ROOT with the value from base_path is not enough because it will break when/if someone overrides the environment variable but does not include a cli arg nor a declaration in the toml config.

[ealmloff]

Another point to note. Simply modifying where we internally set DIOXUS_ASSET_ROOT with the value from base_path is not enough because it will break when/if someone overrides the environment variable but does not include a cli arg nor a declaration in the toml config.

The CLI always either writes DIOXUS_ASSET_ROOT or the meta element. The way this path is communicated to the front end is an implementation detail. We don't support overwriting that environment variable

[binarypie]

Another point to note. Simply modifying where we internally set DIOXUS_ASSET_ROOT with the value from base_path is not enough because it will break when/if someone overrides the environment variable but does not include a cli arg nor a declaration in the toml config.

The CLI always either writes DIOXUS_ASSET_ROOT or the meta element. The way this path is communicated to the front end is an implementation detail. We don't support overwriting that environment variable

I apologize for the confusion here. I assumed that the environment variable was accessible from the comments in the code. I'll revert these and make that change.

[ealmloff]

Much better, thanks!