Skip to content

fix: check HTTP status in FileStream::from_response #4948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkelleyrtp merged 1 commit into from
Nov 11, 2025
Merged

fix: check HTTP status in FileStream::from_response #4948

jkelleyrtp merged 1 commit into from
Nov 11, 2025

Conversation

@Himmelschmidt
Copy link
Contributor

@Himmelschmidt Himmelschmidt commented Nov 10, 2025

Closes #4947

Adds HTTP status code checking to FileStream::from_response() so server errors are properly propagated to the client as Err(ServerFnError) instead of Ok(FileStream).

@Himmelschmidt Himmelschmidt requested a review from a team as a code owner November 10, 2025 15:07
@jkelleyrtp jkelleyrtp merged commit 317abed into DioxusLabs:main Nov 11, 2025
18 of 19 checks passed
@jkelleyrtp
Copy link
Member

jkelleyrtp commented Nov 11, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkelleyrtp jkelleyrtp jkelleyrtp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FileStream error handling

2 participants

@Himmelschmidt @jkelleyrtp