Skip to content

Fix windows builds #4903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkelleyrtp merged 1 commit into from
Nov 4, 2025
Merged

Fix windows builds #4903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/cli/src/build/request.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -908,7 +908,7 @@ impl BuildRequest {
]);
}

// On windows, we pass /SUBSYSTbEM:WINDOWS to prevent a console from appearing
// On windows, we pass /SUBSYSTEM:WINDOWS to prevent a console from appearing
if matches!(bundle, BundleFormat::Windows)
&& !rustflags
.flags
Expand All @@ -922,6 +922,11 @@ impl BuildRequest {
rustflags
.flags
.push(format!("-Clink-arg=/SUBSYSTEM:{}", subsystem));
// We also need to set the entry point to mainCRTStartup to avoid windows looking
// for a WinMain function
rustflags
.flags
.push("-Clink-arg=/ENTRY:mainCRTStartup".to_string());
}

// Make sure we set the sysroot for ios builds in the event the user doesn't have it set
Expand Down
Loading