fix: tokio rt is not set when calling handlers #4850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4847
I think something changed in wry/tao since using tokio RT used to work without needing to manually enter the runtime.
Tao on android has weird problems with thread safety and locking. Looking at the stack trace, it seems that
handleRequestis called from wry in a thread that tokio was never used on. That doesn't make much sense to me, but I imagine it might be a java thread that existed before ourmainthread.This PR just drags the runtime along into the async protocols, fixing the bug. I imagine there might be other similar issues with global runtimes we might need to look at later, but can't quite tell.