Skip emitting a transposed type if the original type is entirely generic #4838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transpose operation on stores pushes the reactivity one layer deeper into the type. For example, transposing
Store<Result<T, E>>gives youResult<Store<T>, Store<E>>.The store macro creates a transposed version of every type with the fields replaced with their store variants. For types similar to Result and Option with only generic fields, the transposed version of the type is more difficult to name during matching.
This PR adjusts the macro logic to only emit a type alias all fields of the item we are deriving store on are generic. This makes it possible to match on the transposed version of the item as normal: