fix(cli): correct Android toolchain target for 32-bit arm architectures #4837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When I run
dx serve --android --device 192.168.0.2:5555 --target armv7-linux-androideabion a physical Android 12 device with a 32-bit ARM architecture, I get a build error.Fix
Update the CLI so that, consistent with the other parts of the CLI, the NDK architecture for 32-bit ARM is treated as
armv7a.AndroidTools::clang_pathnow uses"armv7a-linux-androideabi"for all 32-bit ARM architectures."armv7l"and"armv8l"asArchitecture::Arm(ArmArchitecture::Arm), ensuring that both variants are recognized as ARM and handled correctly. (My physical device wasarmv8l)dx doctor