-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Support public dir
#4783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support public dir
#4783
Conversation
- add optional application.static_dir field defaulting to none - copy configured static directory into web output during build/serve - document config knob and add unit tests - force full rebuild when static_dir contents change - sync removes stale outputs and logs copy activity - track static manifest next to platform dir Tests: cargo fmt
|
Haha I didn't default it to |
|
The asset system is already quite sophisticated so I changed this PR to just use that instead. Every file the public dir gets submitted into the asset system with hashing disabled. Our existing memoization system takes care of the rest. I also adjusted things to merge the manifest together with the .cli-version fle we generate so we now have a Now, you can load that file and read its contents at runtime if you so choose. We'll add more to it eventually for deploy-related features. NextJS supports a number of things like sitemap generation - we can probably re-use the public dir as a place to dump the output. |
Tests: cargo fmt