Skip to content

Fix opening in new tab with internal links #4677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkelleyrtp merged 1 commit into from
Sep 21, 2025
Merged

Fix opening in new tab with internal links #4677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/router/src/components/link.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,11 @@ pub fn Link(props: LinkProps) -> Element {
return;
}

// If we need to open in a new tab, let the browser handle it
if new_tab {
return;
}

// todo(jon): this is extra hacky for no reason - we should fix prevent default on Links
if do_default && is_external {
return;
Expand Down
Loading