Skip to content

Conversation

@ealmloff
Copy link
Member

Fixes #4535

@ealmloff ealmloff requested a review from a team as a code owner August 15, 2025 15:24
@ealmloff ealmloff added bug Something isn't working cli Related to the dioxus-cli program labels Aug 15, 2025
@ealmloff ealmloff marked this pull request as draft August 15, 2025 16:27
@ealmloff ealmloff marked this pull request as ready for review August 15, 2025 16:33
@jkelleyrtp
Copy link
Member

jkelleyrtp commented Aug 15, 2025

Technically the show_cursor code is meant for the dx new and dx init commands in the event cargo generate fails. The TUI being active is not set there, so we wouldn't be catching that case.

We can extract the tui_active bool back to a static and then set it in the relevant places. Should be nicer to not pass it around as an arg.

I think there might be a way to check if "alternate mode" is enabled without our own book. IIRC there's a method on stdout that lets you check

@ealmloff
Copy link
Member Author

Ah, tui_active will also silence logs which I don't think we want for the dx new and dx init commands. I switched to checking if stdout is a terminal

@jkelleyrtp jkelleyrtp merged commit 418b747 into DioxusLabs:main Aug 15, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cli Related to the dioxus-cli program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dx fmt adding terminal codes to output in rc.0

2 participants