Skip to content

Allow user to specify =false for default true flags #4467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkelleyrtp merged 1 commit into from
Jul 24, 2025
Merged

Allow user to specify =false for default true flags #4467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/cli/src/cli/target.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ pub(crate) struct TargetArgs {
pub(crate) skip_assets: bool,

/// Inject scripts to load the wasm and js files for your dioxus app if they are not already present [default: true]
#[clap(long, default_value_t = true, help_heading = HELP_HEADING)]
#[clap(long, default_value_t = true, help_heading = HELP_HEADING, num_args = 0..=1)]
pub(crate) inject_loading_scripts: bool,

/// Experimental: Bundle split the wasm binary into multiple chunks based on `#[wasm_split]` annotations [default: false]
Expand All @@ -105,7 +105,7 @@ pub(crate) struct TargetArgs {
///
/// This will make the binary larger and take longer to compile, but will allow you to debug the
/// wasm binary
#[clap(long, default_value_t = true, help_heading = HELP_HEADING)]
#[clap(long, default_value_t = true, help_heading = HELP_HEADING, num_args = 0..=1)]
pub(crate) debug_symbols: bool,

/// Are we building for a device or just the simulator.
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/cli/update.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ pub(crate) struct SelfUpdate {
pub version: Option<String>,

/// Install the update.
#[clap(long, default_value = "true")]
#[clap(long, default_value = "true", num_args = 0..=1)]
pub install: bool,

/// List available versions.
Expand Down
Loading