Skip to content

Conversation

@ealmloff
Copy link
Member

This fixes two bugs with the asset system:

  1. Assets with multiple extensions like foo.tar.gz lost the hash because the second extension with the hash (tar-hash) was replaced instead of pushing a the final extension
  2. If the asset system includes two files with an identical content hash, but different source paths they were not deduplicated and one of the threads will fail to write the duplicate asset to the output path

Fixes #4432

@ealmloff ealmloff requested a review from a team as a code owner July 18, 2025 13:56
@ealmloff ealmloff added bug Something isn't working cli Related to the dioxus-cli program manganis Related to the manganis crate labels Jul 18, 2025
@jkelleyrtp jkelleyrtp merged commit 71b00ab into DioxusLabs:main Jul 18, 2025
20 checks passed
@jkelleyrtp
Copy link
Member

Works on the docsite 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cli Related to the dioxus-cli program manganis Related to the manganis crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Javascript assets with atypical endings aren't properly invalidated from the asset cache

2 participants