fix: use the rustc env for linking too, hopefully fixing windows #4172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bushrat011899
left a comment
There was a problem hiding this comment.
This works much more reliably for me on Windows 10, thanks!
AnteDeliria
pushed a commit
to AnteDeliria/dioxus
that referenced
this pull request
Jun 2, 2025
AnteDeliria
pushed a commit
to AnteDeliria/dioxus
that referenced
this pull request
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my windows
Administrator: ARM64 Native Tools Command Prompt for VS 2022 (2)command prompt, the various sysroots seem to be set fine when doing compiles/linking.However, it seems that the default command prompt does not set these variables, and that rustc figures out the sysroot for windows manually and adds stuff like
ntdll.dllto the path. This PR just steals the environment set by the rust compiler and replicates it for the linking commands, preserving the behavior of a typical rust compile.