Skip to content

fix: escape backslashes in debug locations for HTMLData serialization #4116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkelleyrtp merged 4 commits into from
May 30, 2025
Merged

fix: escape backslashes in debug locations for HTMLData serialization #4116

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c314fc
fix: escape backslashes in debug locations for HTMLData serialization
ckaspian May 14, 2025
faf1f41
Move position of double escaping and switch to literals.
ckaspian May 14, 2025
5f75482
escape newlines and quotes
ealmloff May 14, 2025
1b6648a
fix formatting
ealmloff May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/fullstack-protocol/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,13 @@ impl HTMLData {
#[cfg(debug_assertions)]
debug_types: format_js_list_of_strings(&self.debug_types),
#[cfg(debug_assertions)]
debug_locations: format_js_list_of_strings(&self.debug_locations),
debug_locations: format_js_list_of_strings(
&self
.debug_locations
.iter()
.map(|s| Some(s.as_ref().unwrap().replace("\\", "\\\\").to_string()))
.collect::<Vec<_>>(),
),
}
}
}
Expand Down