Fix websocket server functions and add an example #4107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkelleyrtp
approved these changes
May 14, 2025
AnteDeliria
pushed a commit
to AnteDeliria/dioxus
that referenced
this pull request
Jun 2, 2025
* Fix websocket server function * Add websocket test * add a websocket example * fix clippy
AnteDeliria
pushed a commit
to AnteDeliria/dioxus
that referenced
this pull request
Jul 23, 2025
* Fix websocket server function * Add websocket test * add a websocket example * fix clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new logic to override different parts of the server function response broke the websocket server function protocol because it always set the response status to 200 by default. This PR fixes the issue by tracking what parts of the response have been written to and only writing those back to the final response
Fixes #4100
TODO: