Fix: Eval Prematurely Dropping #3877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkelleyrtp
approved these changes
Apr 15, 2025
AnteDeliria
pushed a commit
to AnteDeliria/dioxus
that referenced
this pull request
Jun 2, 2025
AnteDeliria
pushed a commit
to AnteDeliria/dioxus
that referenced
this pull request
Jul 23, 2025
jongiddy
added a commit
to jongiddy/cf-dioxus
that referenced
this pull request
Sep 7, 2025
The `web` feature uses code that expects to run in a browser with web objects including `window`. Workers code provides a JS environment without these objects. As an example, see the `eval` implementation in DioxusLabs/dioxus#3877 (added in Dioxus 0.7).
jongiddy
added a commit
to jongiddy/cf-dioxus
that referenced
this pull request
Sep 7, 2025
The `web` feature uses code that expects to run in a browser with web objects including `window`. Workers code provides a JS environment without these objects. As an example, see the `eval` implementation in DioxusLabs/dioxus#3877 (added in Dioxus 0.7).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eval channel was being garbage collected even though the user's code should still have a hard reference to it.
I spent a while trying to solve the root issue of why the channel is getting GC'ed (maybe some weird async JS GC trickery?), and decided it'd be quicker to implement a system where the channel is only dropped when we manually
dioxus.close();it. The close method is already called internally and won't need to be called by the user.Fixes #2979