fix(fullstack): Resolve suspense before the head chunk when streaming is disabled #3829
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move suspense handling to the correct position in the SSR renderer to ensure proper rendering when streaming is disabled.
ealmloff
approved these changes
Mar 5, 2025
Member
ealmloff
left a comment
There was a problem hiding this comment.
Thanks, this looks right. We should wait for suspense to resolve when streaming is disabled before rendering the head chunk
jkelleyrtp
approved these changes
Mar 5, 2025
AnteDeliria
pushed a commit
to AnteDeliria/dioxus
that referenced
this pull request
Jun 2, 2025
…#3829) Move suspense handling to the correct position in the SSR renderer to ensure proper rendering when streaming is disabled.
AnteDeliria
pushed a commit
to AnteDeliria/dioxus
that referenced
this pull request
Jul 23, 2025
…#3829) Move suspense handling to the correct position in the SSR renderer to ensure proper rendering when streaming is disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move suspense handling to the correct position in the SSR renderer to ensure proper rendering when streaming is disabled.
Issues
Metatag does not be rendered after suspense.SEOby suspenseMetaBefore
Metas before suspense.Contribution
Metas after resolving suspense