Provide HotkeyState on Global Shortcut Events
#3822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The global shortcuts are otherwise also triggering when the hotkey is being released. This affects at least Windows.
Member
|
I feel like the handlers should still be called and the selection is done in user code. Someone might want to handle released events? |
Contributor
Author
|
That would require public API changes, but I can definitely implement it that way. |
HotkeyState on Global Shortcut Events
Instead of ignoring the events where the shortcut is released, the state is now provided as an argument to the event handler.
Contributor
Author
|
This should be ready to be reviewed again. It includes the breaking changes now. |
jkelleyrtp
approved these changes
Apr 9, 2025
Member
jkelleyrtp
left a comment
There was a problem hiding this comment.
Thank you! Sorry this sat for so long.
This was referenced Apr 15, 2025
AnteDeliria
pushed a commit
to AnteDeliria/dioxus
that referenced
this pull request
Jun 2, 2025
* Only react to hotkeys that are pressed The global shortcuts are otherwise also triggering when the hotkey is being released. This affects at least Windows. * Provide `HotkeyState` on Global Shortcut Events Instead of ignoring the events where the shortcut is released, the state is now provided as an argument to the event handler.
AnteDeliria
pushed a commit
to AnteDeliria/dioxus
that referenced
this pull request
Jun 3, 2025
* Only react to hotkeys that are pressed The global shortcuts are otherwise also triggering when the hotkey is being released. This affects at least Windows. * Provide `HotkeyState` on Global Shortcut Events Instead of ignoring the events where the shortcut is released, the state is now provided as an argument to the event handler.
AnteDeliria
pushed a commit
to AnteDeliria/dioxus
that referenced
this pull request
Jul 23, 2025
* Only react to hotkeys that are pressed The global shortcuts are otherwise also triggering when the hotkey is being released. This affects at least Windows. * Provide `HotkeyState` on Global Shortcut Events Instead of ignoring the events where the shortcut is released, the state is now provided as an argument to the event handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This state is now provided as an argument to the event handler, such that the user can decide whether to react to the global shortcut being released or not.