Changes to support axum 0.8 #3820
Conversation
|
The change to the cli/src/serve/server.rs was done after reading this. Are there any other tests I should do for the fullstack-auth example? Personally I am not fond of it. I have chosen to use Max Countryman's tower-sessions and axum-login as I found them easier to understand. The community seems to agree with that sentiment looking at the stars for the repos. At some point I will make an example for it. Lastly, I noted that the command used in the CI/CD pipeline for checking is |
|
@ealmloff would you have any guidance on what the problem is with the playwright test? |
My guess is some of the CLI changes are causing it to not proxy the fullstack server. Try going into one of the playwright tests and running the server command manually then opening the site |
|
I pulled in the latest git version of server_fn which includes leptos-rs/leptos#3725. That makes our server function integration much simpler. The server fn crate has a 0.8 beta out, but it doesn't include that change yet. It sounds like a full 0.8 release is coming soon The windows CI issue is unrelated to this PR |
jkelleyrtp
left a comment
There was a problem hiding this comment.
Would like to follow this up with the other PR that moves everything over to axum 0.8, but this is good for now!
I moved us to the 0.8 pre-release of server_fn though we might just end up forking it.
* changes to support axum 0.8 * fixing ci/cd failures. I would like advice on the change to cli/server * putting back in something I took out because I am retarded * update server function revision * remove playwright test results * clippy --------- Co-authored-by: Evan Almloff <[email protected]> Co-authored-by: Jonathan Kelley <[email protected]>
* changes to support axum 0.8 * fixing ci/cd failures. I would like advice on the change to cli/server * putting back in something I took out because I am retarded * update server function revision * remove playwright test results * clippy --------- Co-authored-by: Evan Almloff <[email protected]> Co-authored-by: Jonathan Kelley <[email protected]>
Hi guys. Very excited to make my first, small, contribution.
Before this PR can be closed, the
server_fnandserver_fn_macrodependencies need to be pointed to their released crates once those are available.I was not able to do the make tests but I don't think it's because of this. See below. Any guidance on how I could make this work?
I plugged this is my wannabe website project and it worked fine.
Closes #3479