Skip to content

Conversation

@sehnryr
Copy link
Contributor

@sehnryr sehnryr commented Feb 13, 2025

scrollTo missed a boolean return value so upstream queries (like in DesktopElement) couldn't deserialize any bool, and calls to scroll_to would always result in an error.

let fut = self.query.new_query::<bool>(&script, webview).resolve();

@sehnryr sehnryr requested a review from a team as a code owner February 13, 2025 13:02
Copy link
Member

@jkelleyrtp jkelleyrtp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, thanks!

@jkelleyrtp jkelleyrtp merged commit c13fb06 into DioxusLabs:main Feb 13, 2025
17 checks passed
AnteDeliria pushed a commit to AnteDeliria/dioxus that referenced this pull request Jun 2, 2025
)

* fix(interpreter): missing scrollTo boolean return value

* docs(examples): unwrap scroll_to instead of discarding result values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants