-
-
Notifications
You must be signed in to change notification settings - Fork 433
Fixes in corpus minimizer #3403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I see 3. was already resolved in 7f0afe8 |
This reverts commit 4cb3507.
All locations reading from the lockfile expect an integer as a string,
but in `InMemoryOnDiskCorpus<I>::remove_testcase` the raw bytes of the
integer are written to the file in little endian byte order.
This may cause "ParseIntError { kind: InvalidDigit }" in e.g.
`InMemoryOnDiskCorpus<I>::save_testcase` during parsing of the file's
contents.
Fix this by writing the integer to the lockfile as a string in
`InMemoryOnDiskCorpus<I>::remove_testcase` as well.
|
can you resolve the conflicts? |
yes it's not very good. |
|
Some jobs fail due to connection errors apparently. |
|
thank you! |
Description
In an attempt to implement the corpus minimizer in TNO-S3/WuppieFuzz#146 I stumbled on some issues with the current implementation. My feeling is that parts of the code were unmaintained for too long.
I made a couple of adjustments to get it operational again.
exec_timeis set. In my use caseexec_timewas not set as we want to minimize before starting a fuzzing run.ctrString contains null bytes (string has the form\u{3}000and therefore can't be cast to u32.For all these adjustments I am looking forward to your suggestions. In particular,
readinstead ofread_exactwhich is not preferred and not allowed by the rules set in the precommit, suggestions are much appreciated. Weirdly sometimes the read buffer contains a single digit, and sometimes it contains four bytes (single digit + three null bytes). I can't get my head around it.Checklist
./scripts/precommit.shand addressed all comments