fix: remove refine decision & bug fix (#1031)

* remove refine decision & bug fix

* code simpler

* fix CI

---------

Co-authored-by: Xu Yang <[email protected]>

Author: peteryang1

rdagent/core/proposal.py

@@ -57,12 +57,10 @@ def __init__(
         *,
         code_change_summary: str | None = None,
         decision: bool,
-        refine_decision: bool = False,
         eda_improvement: str | None = None,
         exception: Exception | None = None,
     ) -> None:
         self.decision = decision
-        self.refine_decision = refine_decision
         self.eda_improvement = eda_improvement
         self.reason = reason
         # Exception is not None means failing to generate runnable experiments due to exception.
@@ -100,13 +98,11 @@ def __init__(
         *,
         code_change_summary: str | None = None,
         decision: bool,
-        refine_decision: bool = False,
         eda_improvement: str | None = None,
     ) -> None:
         super().__init__(
             reason,
             decision=decision,
-            refine_decision=refine_decision,
             code_change_summary=code_change_summary,
             eda_improvement=eda_improvement,
         )

rdagent/scenarios/data_science/dev/feedback.py

@@ -102,7 +102,6 @@ def generate_feedback(self, exp: DSExperiment, trace: DSTrace) -> ExperimentFeed
                 if evaluation_not_aligned
                 else convert2bool(dict_get_with_warning(resp_dict, "Replace Best Result", "no"))
             ),
-            refine_decision=convert2bool(dict_get_with_warning(resp_dict, "Refine Decision", "no")),
             eda_improvement=dict_get_with_warning(resp_dict, "EDA Improvement", "no"),  # EDA improvement suggestion
         )
 

rdagent/scenarios/data_science/proposal/exp_gen/base.py

@@ -226,7 +226,7 @@ def sota_experiment_fb(
                 # the sota exp should be accepted decision and all required components are completed.
                 if ef.decision:
                     return exp, ef
-        return None, None
+        return None
 
     def sota_experiment(
         self,

rdagent/scenarios/data_science/proposal/exp_gen/proposal.py

@@ -21,7 +21,6 @@
 from rdagent.scenarios.data_science.proposal.exp_gen.base import DSHypothesis, DSTrace
 from rdagent.scenarios.data_science.proposal.exp_gen.draft import DSDraftExpGen
 from rdagent.scenarios.data_science.proposal.exp_gen.idea_pool import DSIdea
-from rdagent.scenarios.data_science.proposal.exp_gen.refine import DSRefineExpGen
 from rdagent.utils.agent.tpl import T
 from rdagent.utils.repo.diff import generate_diff_from_dict
 from rdagent.utils.workflow import wait_retry
@@ -721,7 +720,7 @@ def task_gen(
         hypotheses: list[DSHypothesis],
         pipeline: bool,
         failed_exp_feedback_list_desc: str,
-        sota_exp_fb: ExperimentFeedback | None = None,
+        fb_to_sota_exp: ExperimentFeedback | None = None,
     ) -> DSExperiment:
         if pipeline:
             component_info = get_component("Pipeline")
@@ -740,7 +739,7 @@ def task_gen(
             sota_exp_desc=sota_exp_desc,
             hypotheses=hypotheses,
             failed_exp_and_feedback_list_desc=failed_exp_feedback_list_desc,
-            eda_improvement=sota_exp_fb.eda_improvement if sota_exp_fb else None,
+            eda_improvement=fb_to_sota_exp.eda_improvement if fb_to_sota_exp else None,
         )
         response = APIBackend().build_messages_and_create_chat_completion(
             user_prompt=user_prompt,
@@ -824,7 +823,11 @@ def gen(
                 ]
             )
 
-        sota_exp, sota_exp_fb = trace.sota_experiment_fb()
+        if sota_exp_fb := trace.sota_experiment_fb() is None:
+            sota_exp, fb_to_sota_exp = None, None
+        else:
+            sota_exp, fb_to_sota_exp = sota_exp_fb
+
         if not isinstance(sota_exp, DSExperiment):
             eda_output = None
         else:
@@ -922,5 +925,5 @@ def gen(
             ),
             pipeline=pipeline,
             failed_exp_feedback_list_desc=failed_exp_feedback_list_desc,
-            sota_exp_fb=sota_exp_fb,
+            fb_to_sota_exp=fb_to_sota_exp,
         )