Fix Internal server error on /verify (#2735)

shouryagautam · web-flow · commit 086fcad7d958 · 2025-08-18T14:39:42.000Z
* converted the returned error to an httpError
diff --git a/hscontrol/handlers.go b/hscontrol/handlers.go
@@ -91,7 +91,7 @@ func (h *Headscale) handleVerifyRequest(
 
 	var derpAdmitClientRequest tailcfg.DERPAdmitClientRequest
 	if err := json.Unmarshal(body, &derpAdmitClientRequest); err != nil {
-		return fmt.Errorf("cannot parse derpAdmitClientRequest: %w", err)
+		return NewHTTPError(http.StatusBadRequest, "Bad Request: invalid JSON", fmt.Errorf("cannot parse derpAdmitClientRequest: %w", err))
 	}
 
 	nodes, err := h.state.ListNodes()

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ func (h *Headscale) handleVerifyRequest(`
`91`	`91`
`92`	`92`	`var derpAdmitClientRequest tailcfg.DERPAdmitClientRequest`
`93`	`93`	`if err := json.Unmarshal(body, &derpAdmitClientRequest); err != nil {`
`94`		`- return fmt.Errorf("cannot parse derpAdmitClientRequest: %w", err)`
	`94`	`+ return NewHTTPError(http.StatusBadRequest, "Bad Request: invalid JSON", fmt.Errorf("cannot parse derpAdmitClientRequest: %w", err))`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`nodes, err := h.state.ListNodes()`